Fill out LIBPATH_list and PATH_list in fake JLLs
#39507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yet another minor tweak to the JLLWrappers-conformance of these packages to make them look a little bit more like "normal" JLLs.
KristofferC
pushed a commit
that referenced
this pull request
Feb 5, 2021
Yet another minor tweak to the JLLWrappers-conformance of these packages to make them look a little bit more like "normal" JLLs. (cherry picked from commit 658ee46)
KristofferC
reviewed
Feb 5, 2021
| init_p7zip_path() | ||
| global PATH[] = dirname(p7zip_path) |
There was a problem hiding this comment.
No need for global here? Also, why isn't PATH a const?
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
Yet another minor tweak to the JLLWrappers-conformance of these packages to make them look a little bit more like "normal" JLLs.
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
Yet another minor tweak to the JLLWrappers-conformance of these packages to make them look a little bit more like "normal" JLLs.
staticfloat
added a commit
that referenced
this pull request
Dec 23, 2022
Yet another minor tweak to the JLLWrappers-conformance of these packages to make them look a little bit more like "normal" JLLs. (cherry picked from commit 658ee46)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another minor tweak to the JLLWrappers-conformance of these packages
to make them look a little bit more like "normal" JLLs.