fix part of #38936, getfield elim handling union of tuples #39107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the regression since 1.5
vtjnash
reviewed
Jan 5, 2021
| if n == -1 | ||
| n = length(t.parameters) | ||
| elseif n != length(t.parameters) | ||
| return u |
There was a problem hiding this comment.
we could also bin them by length/type, but I suppose the observation is that this caller doesn't need that?
vtjnash
reviewed
Jan 5, 2021
| ts = uniontypes(u) | ||
| n = -1 | ||
| for t in ts | ||
| if t isa DataType && t.name === Tuple.name && !isvarargtype(t.parameters[end]) |
There was a problem hiding this comment.
We might still want to identify Tuple{Vararg{Integer, 2}} as equivalent to Tuple{Integer, Integer}? Though it would be much more complex.
vtjnash
approved these changes
Jan 5, 2021
|
@JeffBezanson Thank you. This works splendidly on our benchmark. 1.7.0-DEV.235 (~162μs) vs 1.7.0-DEV.207 (~246μs) vs 1.5.3 (~180μs). |
KristofferC
pushed a commit
that referenced
this pull request
Jan 8, 2021
This fixes the regression since 1.5 (cherry picked from commit c70a5bc)
staticfloat
pushed a commit
that referenced
this pull request
Jan 15, 2021
This fixes the regression since 1.5 (cherry picked from commit c70a5bc)
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
…uliaLang#39107) This fixes the regression since 1.5
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
This fixes the regression since 1.5 (cherry picked from commit c70a5bc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the regression since 1.5, but not the slowdown due to removing
mutable(which exists in multiple versions).