Fix jl_new_task to avoid allocating stack twice #39065
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user requested dedicated stack of a certain size, then
jl_new_task
immediately allocates the stack by invokingjl_alloc_fiber
.However, it also later nulls
t->stkbuf
. As a result,ctx_switch
invokesjl_alloc_fiber
again to allocate another stack.An alternate fix (assuming my explanation above is even correct...) might be to not pre-allocate the stack here, and leave that to
ctx_switch
.Resolves #36361