Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cross-compilation of libjulia #37723

Merged
merged 4 commits into from
Dec 14, 2020
Merged

Fix cross-compilation of libjulia #37723

merged 4 commits into from
Dec 14, 2020

Conversation

vchuravy
Copy link
Member

  • Allow flips to be built against system UTF8PROC
  • Use universal LIBUV_INC instead of build_includedir
  • stage flisp.boot into host

x-ref: JuliaPackaging/Yggdrasil#1694

@vchuravy vchuravy requested a review from vtjnash September 23, 2020 23:18
@vchuravy vchuravy mentioned this pull request Sep 24, 2020
Merged
@vchuravy
Copy link
Member Author

vchuravy commented Oct 2, 2020

@vtjnash do these changes look sensible to you?

@vchuravy vchuravy mentioned this pull request Oct 20, 2020
Open
fingolfin
fingolfin approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, it works really well so far in the Yggdrasil basewd libjulia_jll

vtjnash
vtjnash approved these changes Dec 5, 2020
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@musm
Copy link
Contributor

musm commented Dec 14, 2020

Aproved already, can we merge this?

@vchuravy vchuravy merged commit 33cfcc4 into master Dec 14, 2020
@vchuravy vchuravy deleted the vc/use_system branch December 14, 2020 17:57
@musm musm added the backport 1.6 Change should be backported to release-1.6 label Dec 14, 2020
@KristofferC KristofferC mentioned this pull request Jan 5, 2021
Merged
26 tasks
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Jan 6, 2021
@giordano giordano mentioned this pull request Mar 28, 2021
Merged
@carlocab carlocab mentioned this pull request May 4, 2021
Merged
45 tasks
@StefanKarpinski StefanKarpinski added the backport 1.6 Change should be backported to release-1.6 label May 7, 2021
@StefanKarpinski
Copy link
Member

Request to backport ba653ec here. @KristofferC, anything else that needs to be done to make sure that happens?

@StefanKarpinski StefanKarpinski removed the backport 1.6 Change should be backported to release-1.6 label May 7, 2021
@StefanKarpinski
Copy link
Member

Nevermind, I see it's already done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vchuravy @musm @StefanKarpinski @fingolfin @vtjnash @KristofferC