Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codegen: phic/upsilon nodes can be set to undefined #37319

Merged
merged 1 commit into from
Sep 3, 2020
Merged

codegen: phic/upsilon nodes can be set to undefined #37319

merged 1 commit into from
Sep 3, 2020

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Sep 1, 2020

Unlike other nodes, Upsilon nodes can be potentially undefined and need
special handling to ensure they aren't literally undef, as we might try
to union-copy or gc-root the data later.

Fix #37262

@vtjnash
codegen: phic/upsilon nodes can be set to undefined
e4bb684 
Unlike other nodes, Upsilon nodes can be potentially undefined and need
special handling to ensure they aren't literally undef, as we might try
to union-copy or gc-root the data later.

Fix #37262
@vtjnash vtjnash added compiler:codegen Generation of LLVM IR and native code backport 1.5 labels Sep 1, 2020
@vtjnash vtjnash requested a review from yuyichao September 1, 2020 17:15
@vtjnash vtjnash merged commit 5cf5717 into master Sep 3, 2020
@vtjnash vtjnash deleted the jn/37262 branch September 3, 2020 16:06
@yuyichao yuyichao mentioned this pull request Sep 3, 2020
Merged
@KristofferC KristofferC mentioned this pull request Sep 7, 2020
Merged
29 tasks
KristofferC pushed a commit that referenced this pull request Sep 7, 2020
@vtjnash @KristofferC
codegen: phic/upsilon nodes can be set to undefined (#37319)
42dc946 
Unlike other nodes, Upsilon nodes can be potentially undefined and need
special handling to ensure they aren't literally undef, as we might try
to union-copy or gc-root the data later.

Fix #37262

(cherry picked from commit 5cf5717)
KristofferC pushed a commit that referenced this pull request Sep 8, 2020
@vtjnash @KristofferC
codegen: phic/upsilon nodes can be set to undefined (#37319)
df3fc27 
Unlike other nodes, Upsilon nodes can be potentially undefined and need
special handling to ensure they aren't literally undef, as we might try
to union-copy or gc-root the data later.

Fix #37262

(cherry picked from commit 5cf5717)
KristofferC pushed a commit that referenced this pull request Sep 8, 2020
@vtjnash @KristofferC
codegen: phic/upsilon nodes can be set to undefined (#37319)
0157e27 
Unlike other nodes, Upsilon nodes can be potentially undefined and need
special handling to ensure they aren't literally undef, as we might try
to union-copy or gc-root the data later.

Fix #37262

(cherry picked from commit 5cf5717)
KristofferC pushed a commit that referenced this pull request Sep 10, 2020
@vtjnash @KristofferC
codegen: phic/upsilon nodes can be set to undefined (#37319)
2e95df4 
Unlike other nodes, Upsilon nodes can be potentially undefined and need
special handling to ensure they aren't literally undef, as we might try
to union-copy or gc-root the data later.

Fix #37262

(cherry picked from commit 5cf5717)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuyichao yuyichao Awaiting requested review from yuyichao

Assignees
No one assigned
Labels
compiler:codegen Generation of LLVM IR and native code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

segfault in gc_mark_loop
2 participants
@vtjnash @KristofferC