fix #37282, printing juxtaposition of 0 confusion with hex,bin,oct literals #37308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
approved these changes
Aug 31, 2020
vtjnash
reviewed
Sep 1, 2020
| @@ -1601,7 +1601,10 @@ function show_unquoted(io::IO, ex::Expr, indent::Int, prec::Int, quote_level::In | |||
| # scalar multiplication (i.e. "100x") | |||
| elseif (func === :* && | |||
| length(func_args) == 2 && isa(func_args[1], Union{Int, Int64, Float32, Float64}) && | |||
There was a problem hiding this comment.
Suggested change
| length(func_args) == 2 && isa(func_args[1], Union{Int, Int64, Float32, Float64}) && | |
| length(func_args) == 2 && isa(func_args[1], Union{Int32, Int64, Float32, Float64}) && |
There was a problem hiding this comment.
Nvm, I assume this might have been intentional
vtjnash
approved these changes
Sep 1, 2020
| @@ -1601,7 +1601,10 @@ function show_unquoted(io::IO, ex::Expr, indent::Int, prec::Int, quote_level::In | |||
| # scalar multiplication (i.e. "100x") | |||
| elseif (func === :* && | |||
| length(func_args) == 2 && isa(func_args[1], Union{Int, Int64, Float32, Float64}) && | |||
There was a problem hiding this comment.
Nvm, I assume this might have been intentional
KristofferC
pushed a commit
that referenced
this pull request
Sep 7, 2020
KristofferC
pushed a commit
that referenced
this pull request
Sep 7, 2020
KristofferC
pushed a commit
that referenced
this pull request
Sep 8, 2020
KristofferC
pushed a commit
that referenced
this pull request
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #37282