Symbol clean up and strlen fixes #37149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually the change to |
* Require the symbol to fit in ssize_t This is the limit we have on arrays and I don't think anyone is using symbols that is as long as half the full address space. * Remove some unnecessary embeded NUL byte checks when constructing symbols Almost all use of `jl_symbol_n` have the caller checked for embedded NUL byte already. This technically introduces a C API/ABI breakage but it shouldn't matter on all platforms we support. * Fix ccall of `strlen`.
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2020
* Require the symbol to fit in ssize_t This is the limit we have on arrays and I don't think anyone is using symbols that is as long as half the full address space. * Remove some unnecessary embeded NUL byte checks when constructing symbols Almost all use of `jl_symbol_n` have the caller checked for embedded NUL byte already. This technically introduces a C API/ABI breakage but it shouldn't matter on all platforms we support. * Fix ccall of `strlen`. (cherry picked from commit 98c68a2)
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 29, 2020
* Require the symbol to fit in ssize_t This is the limit we have on arrays and I don't think anyone is using symbols that is as long as half the full address space. * Remove some unnecessary embeded NUL byte checks when constructing symbols Almost all use of `jl_symbol_n` have the caller checked for embedded NUL byte already. This technically introduces a C API/ABI breakage but it shouldn't matter on all platforms we support. * Fix ccall of `strlen`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require the symbol to fit in ssize_t
This is the limit we have on arrays and I don't think anyone is using
symbols that is as long as half the full address space.
Remove some unnecessary embeded NUL byte checks when constructing symbols
Almost all use of
jl_symbol_nhave the caller checked for embedded NUL byte already.This technically introduces a C API/ABI breakage but it shouldn't matter on all platforms we support.
Fix ccall of
strlen.The change to
base/secretbuffer.jlshould be backported. None of the others should. It's funny that the only bug that can cause silent error that I found is in security related code = = ...........