Head off invalidations in to_indices for NTuple{N,Int} #37021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most common argument type for `to_indices` is a tuple of `Int`, yet we rely on the `Integer` fallback. This makes it vulnerable to invalidation by methods like https://github.com/JuliaMath/Interpolations.jl/blob/bcd05a3f0843661104589c31da8d257fecdbe265/src/Interpolations.jl#L273 which would rather convert non-`Int` integers. This prevents approximately 80 MethodInstance invalidations.
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 29, 2020
The most common argument type for `to_indices` is a tuple of `Int`, yet we rely on the `Integer` fallback. This makes it vulnerable to invalidation by methods like https://github.com/JuliaMath/Interpolations.jl/blob/bcd05a3f0843661104589c31da8d257fecdbe265/src/Interpolations.jl#L273 which would rather convert non-`Int` integers. This prevents approximately 80 MethodInstance invalidations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most common argument type for
to_indicesis a tuple ofInt, yet we rely on theIntegerfallback. This makes it vulnerable to invalidation by methods like this one which would rather convert non-Intintegers. This prevents approximately 80 MethodInstance invalidations.