Inline and use a non-splatting combine_axes in broadcast #35260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DifferentialEquations.jl has been carrying around a patch https://github.com/SciML/DiffEqBase.jl/blob/master/src/diffeqfastbc.jl#L18 for awhile which stops allocations like https://discourse.julialang.org/t/strange-allocations-during-broadcasting/26605/5 due to lack of inlining and due to splatting. It would probably be good to upstream this?
KristofferC
reviewed
Mar 25, 2020
KristofferC
reviewed
Mar 25, 2020
|
This code was from @YingboMa so he might comment as well. |
Co-Authored-By: Kristoffer Carlsson <kristoffer.carlsson@chalmers.se>
|
I've found it helpful to add u = rand(100)
k1 = similar(u)
k2 = similar(u)
k3 = similar(u)
k4 = similar(u)
f(a,b,c,d,e) = @. a = a + 1*(b+c+d+e)
@allocated f(u,k1,k2,k3,k4)
@test (@allocated f(u,k1,k2,k3,k4)) == 0 |
mbauman
approved these changes
Mar 25, 2020
oxinabox
pushed a commit
to oxinabox/julia
that referenced
this pull request
Apr 8, 2020
…5260) * Inline and use a non-splatting combine_axes in broadcast * test to ensure no allocations
ravibitsgoa
pushed a commit
to ravibitsgoa/julia
that referenced
this pull request
Apr 9, 2020
…5260) * Inline and use a non-splatting combine_axes in broadcast * test to ensure no allocations
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
* Inline and use a non-splatting combine_axes in broadcast * test to ensure no allocations
ChrisRackauckas
added a commit
to SciML/DiffEqBase.jl
that referenced
this pull request
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DifferentialEquations.jl has been carrying around a patch
https://github.com/SciML/DiffEqBase.jl/blob/master/src/diffeqfastbc.jl#L18
for awhile which stops allocations like https://discourse.julialang.org/t/strange-allocations-during-broadcasting/26605/5 due to lack of inlining and due to splatting. It would probably be good to upstream this?
@mbauman