remove unused macros __FILE_SYMBOL__ and get!
#34611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
added a commit
to aviatesk/MacroTools.jl
that referenced
this pull request
Feb 1, 2020
aviatesk
added a commit
to aviatesk/Lazy.jl
that referenced
this pull request
Feb 1, 2020
aviatesk
added a commit
to aviatesk/Requires.jl
that referenced
this pull request
Feb 1, 2020
aviatesk
added a commit
to JunoLab/CodeTools.jl
that referenced
this pull request
Feb 1, 2020
|
I guess this may be better to be deprecated instead of just removed ? So far I found at least the 4 packages below use it:
(well, I already create patches to them :)) Thoughts ? |
aviatesk
added a commit
to aviatesk/Requires.jl
that referenced
this pull request
Feb 1, 2020
aviatesk
added a commit
to JunoLab/CodeTools.jl
that referenced
this pull request
Feb 1, 2020
aviatesk
added a commit
to aviatesk/MacroTools.jl
that referenced
this pull request
Feb 1, 2020
aviatesk
added a commit
to aviatesk/Lazy.jl
that referenced
this pull request
Feb 1, 2020
aviatesk
added a commit
to aviatesk/Lazy.jl
that referenced
this pull request
Feb 1, 2020
aviatesk
added a commit
to JunoLab/CodeTools.jl
that referenced
this pull request
Feb 1, 2020
|
|
pfitzseb
added a commit
to MikeInnes/Lazy.jl
that referenced
this pull request
Feb 2, 2020
timholy
pushed a commit
to JuliaPackaging/Requires.jl
that referenced
this pull request
Feb 3, 2020
|
Thanks for making all those PRs! |
MikeInnes
added a commit
to FluxML/MacroTools.jl
that referenced
this pull request
Feb 4, 2020
This was referenced Feb 15, 2020
bors bot
added a commit
to FluxML/Zygote.jl
that referenced
this pull request
Feb 22, 2020
517: Remove get! macro r=dhairyagandhi96 a=matsueushi The get! macro is imported but unused. It was deprecated by JuliaLang/julia#34611, JuliaLang/julia#34646 Co-authored-by: matsueushi <matsueushi@gmail.com>
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
KristofferC
pushed a commit
to JuliaPackaging/Requires.jl
that referenced
this pull request
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the first was only used in the deprecation code for the new iteration protocol. The second, IIRC, predates higher-order functions being fast and is no longer used anywhere.