edit(): allow specifying the column for some editors #33760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems nice 👍 |
4e68b96 to
c0e0630
Compare
|
I updated this and added support for it in |
KristofferC
reviewed
May 13, 2022
| @@ -1506,11 +1506,10 @@ fake_repl() do stdin_write, stdout_read, repl | |||
| end | |||
| repl.interface = REPL.setup_interface(repl) | |||
| s = LineEdit.init_state(repl.t, repl.interface) | |||
| LineEdit.edit_insert(s, "1234") | |||
| @show buffercontents(LineEdit.buffer(s)) | |||
c0e0630 to
bda9eaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be useful for #33759 if that gets included. For this use case, it would not be useful to print a warning if the editor can't be opened at a specifed column, so I didn't add a
column_unsupportedvariable similar toline_unsupported. Alternatively, a keyword could be passed to specify whether we want a warning in these cases.