Improve message error in broadcast: "arrays could not be broadcast to a common size" #32866

[dmolina]

Following suggestion from ##30438, I have update messages indicating the distance. Now the error message is:

"arrays could not be broadcast to a common size; computed a dimension with lengths $(length(a)) and $(length(b))"

I consider that good error messages is very important for the user-friendliness. I have suffered the previous error message, and in my opinion it should be changed.

In #30438 it was suggested to use directly "$a", not "$(length(a))", but in that case it always said Base.OneTo(X) and with length says directly "X", when the data is Integer, length is not used but only the direct value "$a".

[mbauman]

This is great, thank you! I know you're just using the wording I myself suggested, but could you change computed to simply got? I don't think there's any recomputation involved here — we're just checking the arguments that broadcast received and are reporting back.

[dmolina]

Thanks you. I have updated the error message as you suggested, changing 'calculated' to 'got'.

[tkoolen]

How does this affect performance, in light of #29688?