Fix #10208 - Unnecessary boxing to call jl_object_id #31771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Apr 19, 2019
| emit_typeof_boxed(ctx, val), | ||
| val.isghost ? ConstantPointerNull::get(T_pint8_derived) : | ||
| ctx.builder.CreateBitCast( | ||
| decay_derived(data_pointer(ctx, val)), |
There was a problem hiding this comment.
Only .ispointer values have pointers (otherwise we just return garbage from data_pointer)
ed06060 to
3923252
Compare
Introduce a fast path that passes the type and the data separately to jl_object_id_. Fixes the allocation performance problems noted in the issue, though the `Foo` version is still approx 4x slower, since the Int version doesn't have to go through a call to compute its hash. Fixing that is future work.
|
This is updated for the .ispointer case. |
vtjnash
approved these changes
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a fast path that passes the type and the data separately
to jl_object_id_. Fixes the allocation performance problems noted
in the issue, though the
Fooversion is still approx 4x slower,since the Int version doesn't have to go through a call to compute
its hash. Fixing that is future work.