some Enum improvements #30924
Merged
some Enum improvements #30924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
reviewed
Jan 31, 2019
base/Enums.jl
Outdated
| namemap[i] = s | ||
| push!(values, i) | ||
| if s in seen | ||
| throw(ArgumentError("names for Enum $typename are not unique")) |
There was a problem hiding this comment.
Should we include the duplicated name in the error message for user convenience, since we know at this point that it's s?
533ad7c to
4f20efe
Compare
- define fewer methods per type - normalize print and show methods - check for duplicate names
4f20efe to
996da74
Compare
jmert
added a commit
to jmert/BitFlags.jl
that referenced
this pull request
Mar 10, 2019
Takes inspiration from JuliaLang/julia#30924.
jmert
added a commit
to jmert/BitFlags.jl
that referenced
this pull request
Mar 10, 2019
Takes inspiration from JuliaLang/julia#30924.
jmert
added a commit
to jmert/BitFlags.jl
that referenced
this pull request
Apr 17, 2020
Duplicates the improvement made to Base's Enums: JuliaLang/julia#30924
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
define fewer methods per type
isless and printing methods can be defined once for all Enums.
normalize print and show methods
showshows the name, prefixed with its defining module based on compactness and visibility, like how types are displayedshowfor text/plain shows the longername::type = valueoutputcheck for duplicate names
We checked for duplicate values, but not names. I assume that was an oversight?