-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update svd.jl #30239
Update svd.jl #30239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you run these doctests locally? I'm pretty sure you wanted A == ...
here...
I think this works fine? Note that it is
|
The dangers of phone reviewing...
… On Dec 3, 2018, at 10:08 AM, Kristoffer Carlsson ***@***.***> wrote:
I think this works fine? Note that it is ≈ (isapprox) and not =. However, there should be spaces between the inputs like
julia> A = rand(4,3);
julia> U,S,V = svd(A);
julia> A ≈ U*Diagonal(S)*V'
true
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Welcome @alanedelman, I see that this is your first pull request to Julia! Would it be better to combine this example with the one below it? |
Tests failing with trailing whitespaces. |
Make doc more useful to the reader.
versions of svd functions.
I've fixed the doctests so they are now passing (the failure on Mac is unrelated). @alanedelman I've reorganized the paragraphs in the generalized svd documentation. The docstrings usually starts with a fairly compact description of inputs and outputs and then gives more details in the following. Please take a look. I've also deleted the examples in the docstrings of the mutating versions and instead made references to the documentation of the non-mutating versions. This should make it easier to maintain the documentation. |
* Update svd.jl * Update svd.jl Make doc more useful to the reader. * Fix grammar and one trailing whitespace * Update svd.jl * Fix doctests * Avoid duplicating documentation between mutating and non-mutating versions of svd functions. * Reorganize generalized svd docstring and doctests * Break some long lines Co-authored-by: Viral B. Shah <viral@juliacomputing.com> Co-authored-by: Andreas Noack <andreas@noack.dk> (cherry picked from commit cec4c32)
* Update svd.jl * Update svd.jl Make doc more useful to the reader. * Fix grammar and one trailing whitespace * Update svd.jl * Fix doctests * Avoid duplicating documentation between mutating and non-mutating versions of svd functions. * Reorganize generalized svd docstring and doctests * Break some long lines Co-authored-by: Viral B. Shah <viral@juliacomputing.com> Co-authored-by: Andreas Noack <andreas@noack.dk>
* Update svd.jl * Update svd.jl Make doc more useful to the reader. * Fix grammar and one trailing whitespace * Update svd.jl * Fix doctests * Avoid duplicating documentation between mutating and non-mutating versions of svd functions. * Reorganize generalized svd docstring and doctests * Break some long lines Co-authored-by: Viral B. Shah <viral@juliacomputing.com> Co-authored-by: Andreas Noack <andreas@noack.dk> (cherry picked from commit cec4c32)
No description provided.