-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LinearAlgebra remove unused export #28684
Conversation
Is it actually useful to export all these factorization types. I don't think they are often constructed explicitly/directly in user code? I sometimes have a name clash while scripting, because I have a variable that is called QR (which has nothing to do with the QR). |
(cherry picked from commit e23515d)
(cherry picked from commit e23515d)
(cherry picked from commit e23515d)
Bump. I assume this is not the right place to ask, but the questions seems to small to open a new issue or Discourse thread. Is it useful that all these types are exported? More generally, should the export list of the standard libraries be that what used to be exported by Julia Base, or the whole list that used to be exported in the corresponding submodules of Base back in the 0.6 days? |
Which ones are not useful?
Yea, I think it is ok for |
My apologies if I was not clear; I meant the factorization types, i.e. Factorization,
BunchKaufman,
Cholesky,
CholeskyPivoted,
Eigen,
GeneralizedEigen,
GeneralizedSVD,
GeneralizedSchur,
Hessenberg,
LU,
LDLt,
QR,
QRPivoted,
LQ,
Schur,
SVD, I don't think these are ever directly called or constructed, but only arise as output of the corresponding lowercase functions. This is different from e.g. |
I think it would be fine not to export the factorization types. As you point out, normal users should never need to use them explicitly. |
(cherry picked from commit e23515d)
(cherry picked from commit e23515d)
(cherry picked from commit e23515d)
Maybe we should CI that nothing exports undefined symbols?