Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move docs inline from helpdb and add a couple doctests #22651

Merged
merged 1 commit into from
Jul 11, 2017

Conversation

xorJane
Copy link
Contributor

@xorJane xorJane commented Jul 1, 2017

I moved some docstrings inline, added a doctest for reverseind, and converted the examples listed in the docstring for signif to doctests.

Thank you and happy weekend!

Ref #22521

full(F)

Reconstruct the matrix `A` from the factorization `F=factorize(A)`.
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Tangent: This docstring for full only captures one of the various meanings of full. Perhaps we should flesh out this docstring? Or not worry about it in anticipation of complete excision of full in this release cycle?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it were me I'd just leave it as-is, since that's a larger task than simply relocating the docstring.

"ailuJ"

julia> for i in 1:length(r)
print(r[reverseind(s, i)])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mysterious s? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@ararslan ararslan added the docs This change adds or pertains to documentation label Jul 1, 2017
Rounds (in the sense of [`round`](@ref)) `x` so that there are `digits` significant digits, under a
base `base` representation, default 10.

```jldoctest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Examples
```jldoctest

`v[reverseind(v,i)] == reverse(v)[i]`. (This can be nontrivial in the case where `v` is a
Unicode string.)

```jldoctest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Examples
```jldoctest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added # Examples to a few other places in the files I touched.

exit([code])

Quit (or control-D at the prompt). The default exit code is zero, indicating that the
processes completed successfully.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does processes being plural here sound redundant / a little off to anyone else?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounded a little off on first read, yes. Technically more correct than a singular equivalent though I suppose.

On that note, the "control-D at the prompt" snippet strikes me as out of place as well. Perhaps could be listed as a synonym instead? Also could use a ref to the quit() docstring.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should maybe note these as future todo cleanups somewhere

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Captured in an intro issue: #22765. Best!

Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (the tangential comments aside)! :)

@Sacha0
Copy link
Member

Sacha0 commented Jul 8, 2017

(Absent objections, requests for time, or someone beating me to it, I plan to merge this tomorrow morning. Best!)

@tkelman tkelman merged commit 62a0ab8 into JuliaLang:master Jul 11, 2017
jeffwong pushed a commit to jeffwong/julia that referenced this pull request Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants