Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove restriction from _trsen wrappers #12802

Merged
merged 1 commit into from
Sep 13, 2015
Merged

Conversation

mfasi
Copy link
Contributor

@mfasi mfasi commented Aug 25, 2015

As pointed out in #12659, options supported by LAPACK should not be restricted. This commit fixes the issue for the _trsen family.

@kshyatt kshyatt added the linear algebra Linear algebra label Aug 25, 2015
@kshyatt
Copy link
Contributor

kshyatt commented Aug 25, 2015

Nice. Is there any way you could add a test for this?

@mfasi mfasi force-pushed the trsen branch 10 times, most recently from e9a388f to abce3fd Compare September 2, 2015 17:06
@mfasi
Copy link
Contributor Author

mfasi commented Sep 2, 2015

@kshyatt Added a few tests. As this PR does not fix a bug, I guess it'll be postponed after the end of the feature freeze.

@kshyatt
Copy link
Contributor

kshyatt commented Sep 2, 2015

Cheers. Thanks for adding tests. @ViralBShah /@Stefan, what are your thoughts about this vs. feature freeze?

jakebolewski added a commit that referenced this pull request Sep 13, 2015
Remove restriction from _trsen wrappers
@jakebolewski jakebolewski merged commit 1eb976e into JuliaLang:master Sep 13, 2015
@mfasi mfasi deleted the trsen branch September 14, 2015 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants