WIP stack scrubbing #10725
Closed
WIP stack scrubbing #10725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overwrite everything on the stack that looks like a pointer to a small julia object with
0xdead00000000 | offsetwhere offset is its position in the memory region.It should allow for guaranteed failure when an object is not rooted on the stack.
Doesn't work yet for big objects (we'll have to do a bit more work since we can't know the size given an interior pointer).
Probably a reasonable first step before conservative stack scanning.
(this branch also reverts Jameson's windows alignment fix because it was making it annoying to debug, but I hope we'll fix it for real before merging this PR).
I managed to crash it on a
make testallrun so there are still missing roots somewhere, this will make it easier to find them hopefully.