Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segfault in Catlab tests on v1.6.0-rc1 but pass on 1.7.0-DEV.599 #39804

Closed
jpfairbanks opened this issue Feb 24, 2021 · 3 comments · Fixed by #39821
Closed

Segfault in Catlab tests on v1.6.0-rc1 but pass on 1.7.0-DEV.599 #39804

jpfairbanks opened this issue Feb 24, 2021 · 3 comments · Fixed by #39821
Assignees
@JeffBezanson
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@jpfairbanks
Copy link
Contributor

When testing 1.6.0-rc1 with the Catlab library, we get a segfault in one test case and an undefined reference error in another (see AlgebraicJulia/Catlab.jl#385). Both tests pass on Julia Version 1.7.0-DEV.599 (2021-02-23)
@JeffBezanson
Copy link
Member

In either case it looks like something that's supposed to be an object reference is actually a NULL pointer. Possibly involves FunctionWrappers.jl.

@jpfairbanks
Copy link
Contributor Author

Thanks for looking in to it Jeff! Should we investigate this further before 1.6.0 is finalized, or is there way to test whether it has been fixed between 1.6.0-rc1 and 1.6.0? I figured that nightly was the easiest way to get an approximate answer to that question.

@vtjnash
Copy link
Member

vtjnash commented Feb 24, 2021

Probably this: #28669 ?

@JeffBezanson JeffBezanson self-assigned this Feb 25, 2021
@JeffBezanson JeffBezanson added the bug Indicates an unexpected problem or unintended behavior label Feb 25, 2021
JeffBezanson added a commit that referenced this issue Feb 25, 2021
@JeffBezanson
fix #39804, ABI handling of structs with String references
ccb517d
@JeffBezanson JeffBezanson mentioned this issue Feb 25, 2021
Merged
JeffBezanson added a commit that referenced this issue Feb 25, 2021
@JeffBezanson
fix #39804, ABI handling of structs with String references
571064a
JeffBezanson added a commit that referenced this issue Feb 26, 2021
@JeffBezanson
fix #39804, ABI handling of structs with String references (#39821)
9ca31f7
KristofferC pushed a commit that referenced this issue Mar 2, 2021
@JeffBezanson @KristofferC
fix #39804, ABI handling of structs with String references (#39821)
cc14111 
(cherry picked from commit 9ca31f7)
@KristofferC KristofferC mentioned this issue Mar 2, 2021
Merged
52 tasks
Closed
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this issue May 4, 2021
@JeffBezanson @ElOceanografo
fix JuliaLang#39804, ABI handling of structs with String references (J…
fe2287f 
…uliaLang#39821)
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this issue May 9, 2021
@JeffBezanson @antoine-levitt
fix JuliaLang#39804, ABI handling of structs with String references (J…
3999be5 
…uliaLang#39821)
staticfloat pushed a commit that referenced this issue Dec 23, 2022
@JeffBezanson @staticfloat
fix #39804, ABI handling of structs with String references (#39821)
a9802a1 
(cherry picked from commit 9ca31f7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeffBezanson JeffBezanson

Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #39804, ABI handling of structs with String references JuliaLang/julia
3 participants
@vtjnash @JeffBezanson @jpfairbanks