Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression (change) in inference after SCC PR #39361

Closed
KristofferC opened this issue Jan 22, 2021 · 0 comments · Fixed by #39375
Closed

Regression (change) in inference after SCC PR #39361

KristofferC opened this issue Jan 22, 2021 · 0 comments · Fixed by #39375
Assignees
@vtjnash
Labels
compiler:inference Type inference regression Regression in behavior compared to a previous version
Milestone
1.6.0

Comments

@KristofferC
Copy link
Member

KristofferC commented Jan 22, 2021 •
edited
Loading

#39116 caused the following change:

julia> using MutableArithmetics

julia> MutableArithmetics.copy_if_mutable(Vector{Int}[])
Any[]
# Vector{Int64}[] before #39116

What is interesting is that when running it through the interpreter it still gives the older ("better") result

julia> using JuliaInterpreter

julia> @interpret MutableArithmetics.copy_if_mutable(Vector{Int}[])
Vector{Int64}[]

This caused a few packages to start failing in the backport branch (for example https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/7d1533d_vs_8240225/MultivariateBases.1.6.0-beta1-85c46c0116.log).

I'll put a 1.6 blocker on this for now, but I don't know if this is expected or how it should be assessed.

cc @vtjnash
@KristofferC KristofferC added regression Regression in behavior compared to a previous version compiler:inference Type inference labels Jan 22, 2021
@KristofferC KristofferC added this to the 1.6 blockers milestone Jan 22, 2021
@vtjnash vtjnash self-assigned this Jan 23, 2021
vtjnash added a commit that referenced this issue Jan 23, 2021
@vtjnash
inference: SCC handling missing for return_type_tfunc
bad9527 
This has actually been broken for a long time, so it only got noticed
when it caused a regression.

Fixes #39361
@vtjnash vtjnash mentioned this issue Jan 23, 2021
Merged
vtjnash added a commit that referenced this issue Jan 25, 2021
@vtjnash
inference: SCC handling missing for return_type_tfunc (#39375)
fd8f97e 
This has actually been broken for a long time, so it only got noticed
when it caused a regression.

Fixes #39361
KristofferC pushed a commit that referenced this issue Jan 26, 2021
@vtjnash @KristofferC
inference: SCC handling missing for return_type_tfunc (#39375)
e8e1765 
This has actually been broken for a long time, so it only got noticed
when it caused a regression.

Fixes #39361

(cherry picked from commit fd8f97e)
KristofferC pushed a commit that referenced this issue Feb 1, 2021
@vtjnash @KristofferC
inference: SCC handling missing for return_type_tfunc (#39375)
baf8414 
This has actually been broken for a long time, so it only got noticed
when it caused a regression.

Fixes #39361

(cherry picked from commit fd8f97e)
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this issue May 4, 2021
@vtjnash @ElOceanografo
inference: SCC handling missing for return_type_tfunc (JuliaLang#39375)
44662d5 
This has actually been broken for a long time, so it only got noticed
when it caused a regression.

Fixes JuliaLang#39361
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this issue May 9, 2021
@vtjnash @antoine-levitt
inference: SCC handling missing for return_type_tfunc (JuliaLang#39375)
adfd590 
This has actually been broken for a long time, so it only got noticed
when it caused a regression.

Fixes JuliaLang#39361
staticfloat pushed a commit that referenced this issue Dec 23, 2022
@vtjnash @staticfloat
inference: SCC handling missing for return_type_tfunc (#39375)
d01dec7 
This has actually been broken for a long time, so it only got noticed
when it caused a regression.

Fixes #39361

(cherry picked from commit fd8f97e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vtjnash vtjnash

Labels
compiler:inference Type inference regression Regression in behavior compared to a previous version
Projects
None yet
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

inference: SCC handling missing for return_type_tfunc JuliaLang/julia
2 participants
@vtjnash @KristofferC