convert -> construct

I like the explicit semantics of conversion, but it's possible it won't be an AbstractString so construction is correct.
JuliaLang · Mar 11, 2022 · fc98cbe · fc98cbe
1 parent bff9c2f
commit fc98cbe
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/base/logging.jl b/base/logging.jl
@@ -674,7 +674,7 @@ function handle_message(logger::SimpleLogger, level::LogLevel, message, _module,
     end
     iob = IOContext(buf, stream)
     levelstr = level == Warn ? "Warning" : string(level)
-    msglines = eachsplit(chomp(convert(String, message)::String), '\n')
+    msglines = eachsplit(chomp(String(message)::String), '\n')
     msg1, rest = Iterators.peel(msglines)
     println(iob, "┌ ", levelstr, ": ", msg1)
     for msg in rest

diff --git a/stdlib/Logging/src/ConsoleLogger.jl b/stdlib/Logging/src/ConsoleLogger.jl
@@ -116,7 +116,7 @@ function handle_message(logger::ConsoleLogger, level::LogLevel, message, _module
 
     # Generate a text representation of the message and all key value pairs,
     # split into lines.
-    msglines = [(indent=0, msg=l) for l in split(chomp(convert(String, message)::String), '\n')]
+    msglines = [(indent=0, msg=l) for l in split(chomp(String(message)::String), '\n')]
     stream = logger.stream
     if !isopen(stream)
         stream = stderr