-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
llvm patch: fix definition of ppc64 SUBFC8 opcode
- Loading branch information
Showing
2 changed files
with
32 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
diff --git a/lib/Target/PowerPC/PPCInstr64Bit.td b/lib/Target/PowerPC/PPCInstr64Bit.td | ||
index 52af293..e7eb8a1 100644 | ||
--- a/lib/Target/PowerPC/PPCInstr64Bit.td | ||
+++ b/lib/Target/PowerPC/PPCInstr64Bit.td | ||
@@ -514,11 +514,11 @@ let Defs = [CARRY] in { | ||
def SUBFIC8: DForm_2< 8, (outs g8rc:$rD), (ins g8rc:$rA, s16imm64:$imm), | ||
"subfic $rD, $rA, $imm", IIC_IntGeneral, | ||
[(set i64:$rD, (subc imm64SExt16:$imm, i64:$rA))]>; | ||
-defm SUBFC8 : XOForm_1r<31, 8, 0, (outs g8rc:$rT), (ins g8rc:$rA, g8rc:$rB), | ||
+} | ||
+defm SUBFC8 : XOForm_1rc<31, 8, 0, (outs g8rc:$rT), (ins g8rc:$rA, g8rc:$rB), | ||
"subfc", "$rT, $rA, $rB", IIC_IntGeneral, | ||
[(set i64:$rT, (subc i64:$rB, i64:$rA))]>, | ||
PPC970_DGroup_Cracked; | ||
-} | ||
defm SUBF8 : XOForm_1r<31, 40, 0, (outs g8rc:$rT), (ins g8rc:$rA, g8rc:$rB), | ||
"subf", "$rT, $rA, $rB", IIC_IntGeneral, | ||
[(set i64:$rT, (sub i64:$rB, i64:$rA))]>; | ||
diff --git a/lib/Target/PowerPC/PPCInstrInfo.cpp b/lib/Target/PowerPC/PPCInstrInfo.cpp | ||
index 313ab88..8dca286 100644 | ||
--- a/lib/Target/PowerPC/PPCInstrInfo.cpp | ||
+++ b/lib/Target/PowerPC/PPCInstrInfo.cpp | ||
@@ -1795,6 +1795,7 @@ bool PPCInstrInfo::optimizeCompareInstr(MachineInstr *CmpInstr, | ||
MI->addOperand(*MI->getParent()->getParent(), | ||
MachineOperand::CreateReg(*ImpUses, false, true)); | ||
} | ||
+ assert(MI->definesRegister(PPC::CR0)); | ||
|
||
// Modify the condition code of operands in OperandsToUpdate. | ||
// Since we have SUB(r1, r2) and CMP(r2, r1), the condition code needs to | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f9fd71b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this upstreamed on trunk?
f9fd71b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tracking url: http://reviews.llvm.org/D20802