-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.10] Fix the trailing task warning on lazy artifacts #3950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5f8a949
to
4e237fd
Compare
10 tasks
maleadt
reviewed
Jul 13, 2024
Co-authored-by: Tim Besard <tim.besard@gmail.com>
An error occurred while trying to automatically change base from
backports-release-1.10
to
release-1.10
July 13, 2024 12:01
Confirmed to fix the issue (on a linux system)
|
Where is this issue discussed for 1.11+? I can confirm that this test case works on a Linux source build of the 1.10 branch but both 1.11.0-rc2 and 1.12.0-DEV.1085 (2024-08-23) from juliaup still give the warning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue where downloading i.e. MKL during precompilation causes the trailing task warning.
It's already fixed on 1.11+ because finalizers (the global Downloader finalizer) runs before the trailing task detector on 1.11+