Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

precompile: collect and show any stderr output as warnings #3319

Merged
merged 2 commits into from
Jan 18, 2023
Merged

precompile: collect and show any stderr output as warnings #3319

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e875309
precompile: collect and show any stderr output as warnings
IanButterworth Jan 14, 2023
4de977a
strip output
IanButterworth Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/API.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1048,7 +1048,7 @@ function _is_stale!(stale_cache::Dict, paths::Vector{String}, sourcepath::String
modpaths = Base.find_all_in_cache_path(modkey)
modfound = false
for modpath_to_try in modpaths::Vector{String}
modstaledeps = get!(() -> Base.stale_cachefile(modkey, modbuild_id, modpath, modpath_to_try),
modstaledeps = get!(() -> Base.stale_cachefile(modkey, modbuild_id, modpath, modpath_to_try),
stale_cache, (modkey, modbuild_id, modpath, modpath_to_try))
if modstaledeps === true
continue
Expand Down Expand Up @@ -1336,6 +1336,7 @@ function precompile(ctx::Context, pkgs::Vector{String}=String[]; internal_call::
fancyprint && print(io, ansi_enablecursor)
end
end
stderr_outputs = Dict{Base.PkgId,String}()
tasks = Task[]
Base.LOADING_CACHE[] = Base.LoadingCache()
## precompilation loop
Expand Down Expand Up @@ -1418,6 +1419,12 @@ function precompile(ctx::Context, pkgs::Vector{String}=String[]; internal_call::
else
rethrow(err)
end
else
# otherwise capture any stderr output as warnings
out = strip(String(take!(iob)))
if !isempty(out)
stderr_outputs[pkg] = out
end
finally
Base.release(parallel_limiter)
end
Expand Down Expand Up @@ -1483,6 +1490,16 @@ function precompile(ctx::Context, pkgs::Vector{String}=String[]; internal_call::
print(iostr, "\n ", color_string("$(length(failed_deps))", Base.error_color()), " dependenc$(plural1) errored. ")
print(iostr, "To see a full report either run `import Pkg; Pkg.precompile()` or load the package$(plural2)")
end
if !isempty(stderr_outputs)
plural1 = length(stderr_outputs) == 1 ? "y" : "ies"
plural2 = length(stderr_outputs) == 1 ? "" : "s"
print(iostr, "\n ", color_string("$(length(stderr_outputs))", Base.warn_color()), " dependenc$(plural1) had warnings during precompilation:")
for (pkgid, err) in stderr_outputs
err = join(split(err, "\n"), color_string("\n│ ", Base.warn_color()))
print(iostr, color_string("\n┌ ", Base.warn_color()), pkgid, color_string("\n│ ", Base.warn_color()), err)
end
print(iostr, color_string("\n└ ", Base.warn_color()))
end
end
let str=str
lock(print_lock) do
Expand Down