Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove usage of hardcoded stdlib list when julia_version == VERSION #3097

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

KristofferC
Copy link
Member

No description provided.

@KristofferC KristofferC requested a review from staticfloat June 1, 2022 12:27
@IanButterworth
Copy link
Member

I'm finding the logic a bit hard to understand here. I'm not sure this does what you want because of the right hand side of the OR

@KristofferC
Copy link
Member Author

KristofferC commented Jun 1, 2022

I only want to do the is_unregistered_stdlib check (which looks up stdlibs from a hardcoded list) when julia_version has been explicitly passed in. That way, inconsistencies in that list only affects users who set custom julia_versions. It is similar to the VERSION check in

Pkg.jl/src/Types.jl

Lines 428 to 430 in 610c768

if !use_historical_for_current_version && julia_version == VERSION
return stdlibs()
end
.

@IanButterworth
Copy link
Member

Ok. Makes sense

Copy link
Member

@staticfloat staticfloat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think I originally had it working this way; it must have changed due to some refactoring at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants