Allow Registry.{add,update}() to target specific depots
#3088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review with the whitespace filter on; I indented a function so it looks like a giant change. |
9a25c1a to
5016536
Compare
Matching many other `Pkg` functions, we allow `update()` here to operate on a custom set of depots, and `add()` to operate on a single specificed depot. This is useful for manipulating registries inside of depots that are not currently on the `DEPOT_PATH`.
5016536 to
f77a4d7
Compare
|
The other way is of course to do the |
|
Yeah, I thought about that, but I'm always wary of manipulating global variables, because I just know someone is going to try and manipulate two depots in two different tasks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matching many other
Pkgfunctions, we allowupdate()here to operateon a custom set of depots, and
add()to operate on a single specificeddepot. This is useful for manipulating registries inside of depots that
are not currently on the
DEPOT_PATH.