Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect uncompressible registry tarballs during update. Add path to error #2998

Closed

Conversation

IanButterworth
Copy link
Member

Tries to help #2997

I wanted to add some guidance like "Try a pkg> registry rm/add" but registry rm tries to load the RegistryInstance so hits the same error.

Saying simply rm regpath also doesn't help because you also need to delete the toml, so the instruction gets a bit long.

Alternatively, could the file hash of the tarball be stored in the registry toml, and it checked in verify_compressed_registry_toml

@IanButterworth
Copy link
Member Author

IanButterworth commented Feb 19, 2022

In place of a faster file integrity check like a file hash, I just added an uncompress check that doesn't store the data.

The uncompress_registry check adds this for first update after boot

0.377624 seconds (1.15 M allocations: 75.317 MiB, 23.83% gc time, 3.35% compilation time)

@IanButterworth IanButterworth changed the title Add pkgerror with path when registry cannot be uncompressed Detect uncompressible registry tarballs during update. Add path to error Feb 19, 2022
@IanButterworth
Copy link
Member Author

Fixed by #3408

@IanButterworth IanButterworth deleted the ib/reg_error_help branch August 13, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant