Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a blacklist for functions that are known to crash Julia when compiled into sysimage #329

Closed
wants to merge 1 commit into from

Conversation

KristofferC
Copy link
Member

Ref #295

@codecov-io
Copy link

codecov-io commented Feb 13, 2020

Codecov Report

Merging #329 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #329   +/-   ##
=======================================
  Coverage   81.18%   81.18%           
=======================================
  Files           2        2           
  Lines         303      303           
=======================================
  Hits          246      246           
  Misses         57       57
Impacted Files Coverage Δ
src/PackageCompiler.jl 80.36% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3106ebc...d0e82d5. Read the comment docs.

@DilumAluthge
Copy link
Member

DilumAluthge commented Feb 14, 2020

@KristofferC Two suggestions:

  1. Instead of making the blacklist a vector of strings, make it a vector of Union{AbstractString, Regex}. That way, you could write a regex that, for example, excludes all of the permutedims statements for all dimensions.
  2. Allow the user to override the default value of precompile_blacklist.

@DilumAluthge
Copy link
Member

I have opened #333, which implements my suggestions.

@KristofferC KristofferC deleted the kc/blacklist branch September 16, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants