-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let muladd
accept arrays
#729
Conversation
Don't we have a 5-arg |
Yes we do, and I guess this uses it on early enough versions. But test failures earlier were from recursive dot issues. |
Ah, I see! |
Test failure on MacOS nightly looks to be that it has a too-old nightly, it passes locally. It might be possible to make the definitions here work on nightly versions between the two PRs above, but won't be easy to avoid ambiguities, and that doesn't seem like a great use of time. |
(Sorry about the noise! Was trying to re-trigger travis. But it seems to be out of credit, in fact.) |
Bump? CI looks happy, tests pass locally on 1.3, 1.4, 1.5. |
Bump |
Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #729 +/- ##
==========================================
+ Coverage 80.64% 81.34% +0.70%
==========================================
Files 4 4
Lines 465 504 +39
==========================================
+ Hits 375 410 +35
- Misses 90 94 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge after CI passes
This adds JuliaLang/julia#37065 ... and JuliaLang/julia#38250 now.