Adds subpixel edge detection and subpixel nonmaxima suppression #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7e2ab98 to
0f4a863
Compare
d7c9e63 to
f5cc9fd
Compare
67f5a35 to
b268728
Compare
Project.toml
Outdated
| ImageCore = "0.8" | ||
| ImageFiltering = "0.6" | ||
| Interpolations = "0.10, 0.11, 0.12" | ||
| MappedArrays = "0.2, 0.3" |
There was a problem hiding this comment.
FYI, it is doable to drop the direct dependency on MappedArrays so that we don't need to maintain the compatibility.
See JuliaImages/ImageFiltering.jl#192 for how it's done.
There was a problem hiding this comment.
Thanks for the excellent suggestion.
b268728 to
368ab94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a work in progress. I need to clean-up the docstrings and finish writing tests that verify the API.