Fix "tmp not defined" in exportimagepixels!() #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timholy
approved these changes
Jan 12, 2020
|
A test would be nice |
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
==========================================
+ Coverage 71.42% 71.77% +0.34%
==========================================
Files 3 3
Lines 371 372 +1
==========================================
+ Hits 265 267 +2
+ Misses 106 105 -1
Continue to review full report at Codecov.
|
|| has higher priority than .= - actually define tmp always - add tests for the direct use of exportimagepixels!()
|
Thanks very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably this typo got exposed because I was calling *exportimagepixels!()` directly.