Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated install help #169

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Remove outdated install help #169

merged 1 commit into from
Dec 4, 2019

Conversation

timholy
Copy link
Member

@timholy timholy commented Nov 29, 2019

@staticfloat, I assume all of this material is outdated now?

@codecov
Copy link

codecov bot commented Nov 29, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@a2f7ed0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #169   +/-   ##
=========================================
  Coverage          ?   69.11%           
=========================================
  Files             ?        2           
  Lines             ?      327           
  Branches          ?        0           
=========================================
  Hits              ?      226           
  Misses            ?      101           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2f7ed0...98fabfe. Read the comment docs.

@timholy
Copy link
Member Author

timholy commented Dec 4, 2019

Bump @staticfloat, @giordano. If we fix this README then we can release a JLL-supporting version of this package.

Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these comments are no longer relevant

@staticfloat staticfloat merged commit 23c79c9 into master Dec 4, 2019
@staticfloat staticfloat deleted the teh/readme branch December 4, 2019 09:24
@staticfloat
Copy link
Contributor

Wow, that feels good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants