Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from LightGraphs to Graphs #30

Merged
merged 5 commits into from
Oct 20, 2021
Merged

Switch from LightGraphs to Graphs #30

merged 5 commits into from
Oct 20, 2021

Conversation

mmiller-max
Copy link
Contributor

@mmiller-max mmiller-max commented Oct 20, 2021 •
edited
Loading

I've made this a breaking change as it switches the AbstractGraph parent type used, which will break anything dispatching on that, for example this abstract typed struct field.

@mmiller-max mmiller-max mentioned this pull request Oct 20, 2021
Closed
@matbesancon
Copy link
Member

thanks a lot! Can you merge #31 into your branch as to get CI on it, then we can merge

@mmiller-max
Copy link
Contributor Author

Sure thing!

@matbesancon matbesancon merged commit e15ade5 into JuliaGraphs:master Oct 20, 2021
@matbesancon
Copy link
Member

thanks!

@mmiller-max
Copy link
Contributor Author

No worries, thanks for reviewing

@mmiller-max mmiller-max deleted the mm/Switch-to-Graphs branch October 20, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmiller-max @matbesancon