Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements #40

Merged
merged 13 commits into from
Feb 24, 2020
Merged

improvements #40

merged 13 commits into from
Feb 24, 2020

Conversation

SimonDanisch
Copy link
Member

  • remove id from observable
  • add project.toml
  • performance improvements
  • small clean ups
  • better stack traces & errors
  • extensions to work with tasks & channels a la generators in obervableshq

@shashi
Copy link
Member

shashi commented Feb 19, 2020

What if I actually want an Observable of Channels? :-p

@travigd are you gonna be ok if Observable.id gets removed?

@SimonDanisch
Copy link
Member Author

bump :)

Btw, I've pretty much used this branch over the last half year, without running into any problems :D

@SimonDanisch
Copy link
Member Author

What if I actually want an Observable of Channels? :-p

Welp ^^ I guess it should be exotic enough to not care? And if not, you can still wrap it, I suppose

SimonDanisch referenced this pull request in SimonDanisch/Bonito.jl Feb 24, 2020
@shashi shashi merged commit 27a2562 into master Feb 24, 2020
@shashi shashi deleted the sd-extensions branch February 24, 2020 16:46
@shashi
Copy link
Member

shashi commented Feb 24, 2020

I guess it should be exotic enough to not care?

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants