Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the requirement of a
SignedDistanceField
from the meshing process and allows direct sampling of a function over a specified bound. See below:I noticed that the current approach is bottlenecked by cache-misses when constructing the voxels. I originally was attempting a caching approach, but suspected this would be faster.
If we include the construction of the SDF in the timings, the non-SDF approach is ~25x faster and allocates orders of magnitude less memory.
This is currently just implemented for Marching Cubes, but I will take a similar approach to the other algorithms as well. Once I clean up the API this should allow me to bring in my Dual Contours examples from Descartes since it requires the function to determine the normals.
TODO: