Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass uv coords directly to GB.Mesh #1161

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Pass uv coords directly to GB.Mesh #1161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ CoordRefSystems = "0.16"
DelaunayTriangulation = "1.0"
Distances = "0.10"
LinearAlgebra = "1.9"
Makie = "0.21, 0.22"
Makie = "0.22"
NearestNeighbors = "0.4"
Random = "1.9"
Rotations = "1.5.1"
Expand Down
2 changes: 1 addition & 1 deletion ext/grid.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@

uv = Makie.@lift [Makie.Vec2f(v, 1 - u) for v in range(0, 1, $vdims[2]) for u in range(0, 1, $vdims[1])]

mesh = Makie.@lift GB.Mesh(Makie.meta($verts, uv=$uv), $quads)
mesh = Makie.@lift GB.Mesh($verts, $quads, uv=$uv)

Check warning on line 83 in ext/grid.jl

View check run for this annotation

Codecov / codecov/patch

ext/grid.jl#L83 

Added line #L83 was not covered by tests

shading = edim == Val(3) ? Makie.FastShading : Makie.NoShading

Expand Down
Loading