More show improvements #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is probably the best example of a 9pm commit I've had so far... in all seriousness we could change the name
This allows the new show methods to also work in e.g arrays.
then, you can actually copy/paste the code
1d6591d to
718f5a3
Compare
|
CI is finally green!! |
rafaqz
approved these changes
Jan 20, 2025
| @@ -80,7 +80,7 @@ test_display(pointm, "Point{false, true}((1, 2, 3))", "Point((1,2,3))") | |||
| pointm_crs = GI.Point((X=1, Y=2, M=3); crs=EPSG(4326)) | |||
| @test parent(pointm_crs) === parent(pointm) | |||
| @test GI.crs(pointm_crs) === EPSG(4326) | |||
| test_display(pointm_crs, "Point{false, true}((1, 2, 3), crs = EPSG{1}((4326,)))", "Point((1,2,3))") | |||
| test_display(pointm_crs, "Point{false, true}((1, 2, 3), crs = \"EPSG:4326\")", "Point((1,2,3))") | |||
There was a problem hiding this comment.
I wonder if showing EPSG as a string is confusing to users who still need to use the constructor
There was a problem hiding this comment.
Agreed, but it's equivalent in most cases that one might care about (Proj and GDAL)
There was a problem hiding this comment.
Maybe we should change show on GFT types to show the constructor too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #177
Fix #176 #182
actual changes
bugfixes and tests