This repository has been archived by the owner on Mar 12, 2021. It is now read-only.
Changes in Conv API #223
Merged
Changes in Conv API #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In #222 I also had a compatibility layer to current NNLib. Not sure if that is really needed but it would allow us to merge this before the NNLib changes land. |
|
bors try |
tryBuild failed |
|
bors try |
tryBuild succeeded |
|
Note that this is an API change; I'll change the current version number so it's clear we need a new minor. |
|
Doesn't this need a REQUIRE update? |
|
As in, bumping the NNlib version? We do need to but NNlib isn't tagged yet. Don't know if there's any downside to just putting a future version in though, given that we do CI with master anyway. |
Yeah, I typically do it early not to forget it when we end up tagging. But it's the same to me, I'm on |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes to the
convAPI of NNlib have been proposed in #54. This PR makes the corresponding changes in order to make it compatible with CuArrays.