Use GPUToolbox.jl #2646
Merged
Use GPUToolbox.jl #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a0d30a to
0b1c4f5
Compare
55849b9 to
62ba3ab
Compare
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/src/device/intrinsics/cooperative_groups.jl b/src/device/intrinsics/cooperative_groups.jl
index b1b5b215e..635f1549c 100644
--- a/src/device/intrinsics/cooperative_groups.jl
+++ b/src/device/intrinsics/cooperative_groups.jl
@@ -32,7 +32,7 @@ using ..LLVMLoopInfo
using Core: LLVMPtr
-using GPUToolbox: @sv_str
+ using GPUToolbox: @sv_str
const cg_debug = false
if cg_debug |
62ba3ab to
54f60fb
Compare
|
Is there a CUDA.jl equivalent to JuliaGPU/Metal.jl#503 where I can report the benchmark segfault? |
|
No, feel free to create an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be gtg if tests pass.
TODO:
[sources]entry