CUSPARSE: Eagerly combine duplicate element on construction. #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2213 +/- ##
===========================================
- Coverage 72.84% 61.39% -11.46%
===========================================
Files 159 154 -5
Lines 14708 14197 -511
===========================================
- Hits 10714 8716 -1998
- Misses 3994 5481 +1487 ☔ View full report in Codecov by Sentry. |
amontoison
reviewed
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2185.
This turned out relatively tricky, as I couldn't find much info on how CUSPARSE handles duplicate entries. Some operations seemed to do so, as shown in the linked issue, however the
SparseArrays.sparsefunction requires support for an arbitrary combinator function. To support that, and make printing work, I added the functionality to eagerly combine duplicate values (requiring 3 kernel launches,O(nnzval)).cc @amontoison, maybe you can review? Can't add you as a reviewer here, maybe it's time to invite you to the JuliaGPU org :-)