Use Cartesian indexing for halve(::AbstractArray) #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkf
added a commit
to tkf/ThreadsX.jl
that referenced
this pull request
Mar 12, 2020
Using commit: Use Cartesian indexing for halve(::AbstractArray) JuliaFolds/SplittablesBase.jl#16 JuliaFolds/SplittablesBase.jl@f2cbeba
tkf
added a commit
to tkf/ThreadsX.jl
that referenced
this pull request
Mar 13, 2020
* Improve foreach for Cartesian style indexing * Fix ThreadsX.foreach(f, xs::AbstractArray) * Use SplittablesBase#master Using commit: Use Cartesian indexing for halve(::AbstractArray) JuliaFolds/SplittablesBase.jl#16 JuliaFolds/SplittablesBase.jl@f2cbeba * Comment on foreach_cartesian_seq * Fix bench_foreach_seq.jl; ns measurements in Julia 1.3 is bad It looks like LLVM is aggressively optimizing the loops and removing them completely. * Test Cartesian style foreach * Add benchmark/bench_foreach.jl * Use SplittablesBase.halve in Cartesian style foreach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.