Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update contributing instructions #274

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Conversation

pfitzseb
Copy link
Collaborator

Fixes #273.

cc @mitiemann

@pfitzseb pfitzseb force-pushed the sp/update-contributing branch from ef7740b to b559756 Compare January 10, 2024 10:23
@mitiemann
Copy link
Contributor

I've ran npm run test on my WSL Ubuntu 22.04 (the current default afaik) which got my a SyntaxError.
npm ci produced

npm WARN EBADENGINE   package: 'mocha@10.2.0',
npm WARN EBADENGINE   required: { node: '>= 14.0.0' },
npm WARN EBADENGINE   current: { node: 'v12.22.9', npm: '8.5.1' }
npm WARN EBADENGINE }

added 116 packages, and audited 117 packages in 1s

25 packages are looking for funding
  run `npm fund` for details

1 high severity vulnerability

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

mtiemann@devicename:~/dev/atom-language-julia$ npm --version
8.5.1
mtiemann@devicename:~/dev/atom-language-julia$ node --version
v12.22.9

I've installed nodejs and npm via apt. I'll find a suitable way to install a more recent version and get back to you.

Copy link
Contributor

@mitiemann mitiemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

README.md Show resolved Hide resolved
pfitzseb and others added 2 commits January 11, 2024 09:30
Co-authored-by: Michael Tiemann <126827163+mitiemann@users.noreply.github.com>
@pfitzseb pfitzseb merged commit 1b7891e into master Jan 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Future development after Atom's sunset
2 participants