Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add public keyword to the grammar #272

Merged

Conversation

mitiemann
Copy link
Contributor

Fixes #271 . This is my first PR here, so any feedback and help appreciated :-)

@pfitzseb
Copy link
Collaborator

pfitzseb commented Jan 8, 2024

This doesn't seem to have any actual grammar changes. Make sure to edit grammars/julia.json and then run the pre-commit hooks.

@mitiemann mitiemann marked this pull request as draft January 9, 2024 18:32
@mitiemann mitiemann marked this pull request as ready for review January 9, 2024 18:39
@mitiemann
Copy link
Contributor Author

My apologies, @pfitzseb , I hadn't marked this as draft. Now it should be completed.

Copy link
Collaborator

@pfitzseb pfitzseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pfitzseb pfitzseb merged commit 3fee1e4 into JuliaEditorSupport:master Jan 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New public keyword not recognized
2 participants