Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove x"" language macro highlighting #252

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

pfitzseb
Copy link
Collaborator

@pfitzseb pfitzseb commented Nov 7, 2021

and remove md highlighting for good.

and remove md highlighting for good
@pfitzseb pfitzseb merged commit f4261ed into master Nov 7, 2021
@pfitzseb pfitzseb deleted the sp/fewer-included-grammars branch November 7, 2021 16:40
@BenPH
Copy link
Contributor

BenPH commented Nov 11, 2021

Ha I had a crack at fixing markdown leaks here and was coming to the same conclusion. Good riddance!

@pfitzseb
Copy link
Collaborator Author

FWIW, I plan to revert this and give #244 (comment) a try.

@BenPH
Copy link
Contributor

BenPH commented Nov 11, 2021

If it helps at all – my attempt does stop leaks except for the case where the markdown is not indented but the quotation marks are. But indented and single line markdown will not get highlighted.

image

It is possible to get indented markdown to highlight since it uses the \G anchor to start many of their patterns – you just need to match the whitespace characters up until the markdown would begin. But all my attempts with this ended up leaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants