Added the possibility to have Type parameters for smart type dispatching #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 21, 2023 12:53
…ing.
Type params (i.e., ::Type{T} anonymous parameters) can be simply discarded from the list of arguments since they are used only for the method dispatching and do not have any sensible nor useful value.
Some tests have been added to check whether type parameters are properly handled.
|
I believe Ben, the original author, might not have the bandwidth to work on ResumableFunctions these days. Thus, I forked the repository into a new Semicoroutines.jl https://github.com/QuantumSavory/Semicoroutines.jl in order to support 1.10 and future julia versions. @liuq , could you consider making this pull request against the fork? As this library is an important part of another project of mine, I plan to provide support at least for the next few years. I am certainly interested in having help from other contributors (and maybe merging things back here if ResumableFunctions.jl is revided). A similar fork is being prepared for SimJulia |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type params (i.e., ::Type{T} anonymous parameters), which are very useful for handling polymorphism-like multiple dispatching, can be simply discarded from the list of arguments since they are used only for the method dispatching and do not have any sensible nor useful value.
In order to do that, the utils.jl file has been modified so that when such a parameter is present (whose name is nothing) it is skipped.
Some tests have been added to check whether type parameters are properly handled.