Broaden promote_rule for Dual to include AbstractIrrational #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
reviewed
Mar 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #687 +/- ##
=======================================
Coverage 89.57% 89.57%
=======================================
Files 11 11
Lines 969 969
=======================================
Hits 868 868
Misses 101 101 ☔ View full report in Codecov by Sentry. |
This was referenced Sep 28, 2024
devmotion
pushed a commit
that referenced
this pull request
Sep 30, 2024
* Broaden promote_rule for Dual to include AbstractIrrational * add IrrationalConstants test dependency * Add tests for AbstractIrrational promote_rule * fix pkg and test bugs
devmotion
pushed a commit
that referenced
this pull request
Sep 30, 2024
* Broaden promote_rule for Dual to include AbstractIrrational * add IrrationalConstants test dependency * Add tests for AbstractIrrational promote_rule * fix pkg and test bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for method ambiguity in #686.
Couldn't tell if/how tests should be updated to reflect this change, happy to do that too if someone more knowledgeable can give me a pointer.