Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make StaticArrays dependency into an extension on v0.11-dev #628

Merged
merged 5 commits into from
Feb 25, 2023

Conversation

ChrisRackauckas
Copy link
Member

@ChrisRackauckas ChrisRackauckas commented Feb 19, 2023

Rebased version of #617. Matches the code of #625

[ Edit: merging this closes #599, closes #617 ]

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2023

Codecov Report

Base: 89.76% // Head: 87.28% // Decreases project coverage by -2.49% ⚠️

Coverage data is based on head (df7e6e0) compared to base (4b143a1).
Patch coverage: 98.83% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #628      +/-   ##
==========================================
- Coverage   89.76%   87.28%   -2.49%     
==========================================
  Files          10       10              
  Lines         967      912      -55     
==========================================
- Hits          868      796      -72     
- Misses         99      116      +17     
Impacted Files Coverage Δ
src/apiutils.jl 100.00% <ø> (ø)
src/dual.jl 80.30% <ø> (-2.48%) ⬇️
src/gradient.jl 98.66% <ø> (-0.29%) ⬇️
src/hessian.jl 100.00% <ø> (+2.43%) ⬆️
src/jacobian.jl 99.15% <ø> (-0.19%) ⬇️
ext/ForwardDiffStaticArraysExt.jl 98.83% <98.83%> (ø)
src/prelude.jl 36.36% <0.00%> (-57.58%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChrisRackauckas
Copy link
Member Author

No objections from anyone? Speak up by Friday?

@ChrisRackauckas
Copy link
Member Author

Same as #625 (comment) , the failure is only on nightly and not v1.9-beta3, and it's the same failure on master according to #626, so it's a nightly issue and unrelated. Merging so that the release and master branches are synced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants