move StaticArrays to extension #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! It does look like one more dispatch needs to move to the extension and it will be good to go. |
| @@ -36,16 +47,15 @@ function finite_difference_hessian( | |||
| cache::HessianCache{T,fdtype,inplace}; | |||
| relstep=default_relstep(fdtype, eltype(x)), | |||
| absstep=relstep) where {T,fdtype,inplace} | |||
| _H = false .* x .* x' | |||
| _H isa SMatrix ? H = MArray(_H) : H = _H | |||
| H = mutable_zeromatrix(x) | |||
There was a problem hiding this comment.
at the start of hessians.jl. uses ArrayInterface.zeromatrix + ArrayInterface.ismutable + Base.copymutable. was looking for something like that in ArrayInterface, but couldn't find it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is a lot of
x isa StaticArray ? Val(false) : Val(true). those were replaced by a wrapper toArrayInterface.ismutable