Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace MissingBackendError with error hint #656

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Dec 5, 2024

The exception we used to throw was hiding the real cause of the error. Now we leave the original MethodError but add an error hint in bold underneath:

image

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.51%. Comparing base (881fc3f) to head (d4f7074).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #656      +/-   ##
==========================================
- Coverage   97.53%   97.51%   -0.03%     
==========================================
  Files         112      111       -1     
  Lines        5561     5546      -15     
==========================================
- Hits         5424     5408      -16     
- Misses        137      138       +1     
Flag Coverage Δ
DI 98.62% <100.00%> (-0.04%) ⬇️
DIT 95.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 3c6e5dc into main Dec 5, 2024
46 of 47 checks passed
@gdalle gdalle deleted the gd/error_hints branch December 5, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant